Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array coercion for array parameters with a $ref schema #274

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

simon816
Copy link
Contributor

@simon816 simon816 commented Aug 5, 2024

Summary

Fixes the array coercion bug as described in detail on: jhthorsen/mojolicious-plugin-openapi#251

A unit test has been written to cover this case.

References

Fixes jhthorsen/mojolicious-plugin-openapi#251

Copy link
Owner

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you want to keep your "blame" I urge you to also perltidy the code. If you don't care, it will look like I made those changes next time I edit the file.

@simon816
Copy link
Contributor Author

simon816 commented Aug 7, 2024

Sure. have run perltidy

@jhthorsen jhthorsen merged commit 6677979 into jhthorsen:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array coersion doesn't work with $ref
2 participants