forked from madeleineudell/LowRankModels.jl
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize package #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jiahao
commented
Mar 28, 2020
- Update CI
- Update requirements files
- Pulls upstream PRs WIP: Get test passing madeleineudell/LowRankModels.jl#96 Remove Float64 restriction madeleineudell/LowRankModels.jl#99 Fix NonNegOneReg madeleineudell/LowRankModels.jl#100
Got tests mostly passing on julia >=1.1 . (cherry picked from commit b5b47cc)
- Delete obsolete REQUIRE - Drop Manifest.toml (let Pkg version resolution do its thing) - .gitignore Manifest - Update dependencies in Project.toml - Drop Julia 1.0 CI support (in preparation for multithreading updates) - Update badges to use CI for fork Signed-off-by: Jiahao Chen <[email protected]>
Throughout the package types are often hard-wired to be Float64. The PR lifts this restriction in some places to allow for any real type. In particular, tihs allows the use of Float32 or Float16 to reduce memory footprint. Structures like `QuadLoss` etc. still require modification in order to not cause conversions to Float64 when computations are made using its fields, but this PR at least allows the user to have data in other formats. (from @baggepinnen) Also removed some old comments about Julia v0.4 (cherry picked from commit 5b82fa8)
(cherry picked from commit 900a777)
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 60.51%
=========================================
Files ? 26
Lines ? 1674
Branches ? 0
=========================================
Hits ? 1013
Misses ? 661
Partials ? 0 Continue to review full report at Codecov.
|
Notes on package modernizationRecommend tool chain (and badges)
General things
TODO
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.