be a bit more lenient on transformers version #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @winglian, the optimizer module itself supports latest transformers dependency, but torchrun_main.py is a bit outdated. I will merge your request once we upgrade torchrun_main.py. |
|
PR can be closed as galore-torch does not require specific transformers version anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Amazing research on this. We're looking to integrate galore into the axolotl project here axolotl-ai-cloud/axolotl#1370
One issue I ran into is the transformers dependency pin is a bit strict, so it would be great if we could loosen it a bit. Thanks!