Add header for ad7150 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a header for ad7150 CDC device. Adjust ad7150 I2C buffer size so we can compile all this nicely. Signed-off-by: Marcelo Schmitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess you may have forgotten to add the header file for ad7150.
I came up with this one for an alternative.
There's also an adjustment to the ad7150 buffer which is small enough to make me feel lazy about splitting the commit.
Still this doesn't work on my setup. Qemu exits with a segfault when trying to create the ad7150 device with
i2c_slave_create_simple(). For now, I commented out the ad7150 stuff to play with ad7280a emulation.I'm using the image you suggested on the mailing list with a mostly equal launch string except I'm also passing the initrd file I found inside the nocloud image.
I'll probably give ad7150 emulation a break to have look at the ad7280 patches. Nevertheless, I'm keen to try suggestions for the ad7150 emulation. :-)