Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): Update django.po for Ukrainian 🇺🇦 #934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DmytroLitvinov
Copy link

No description provided.

@jieter
Copy link
Owner

jieter commented Nov 13, 2023

@DmytroLitvinov thanks for the PR!

Does this only change the case of the first letter of each message? Translations should use the same capitalisation as the original message, unless the language writing rules dictate a capital (i.e. "All German nouns are capitalized.").

Whether or not these capitals are used for other languages is a preference, and should not be dictated by the translation files. If you need uppercase first letters, you should use a custom template with added |capfirst filters.

@DmytroLitvinov
Copy link
Author

Hi @jieter,

in that case, I see that Ukrainian letters are not used for translation.

In our case we are not required as in German provides nouns in capitalized way. It is not required and not strict. And yes, if some even need it - they can use |capfirst as you wrote. I just followed translation file and did in the same register.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants