limit accessible paths #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously one could browse the whole filesystem on the machine that `snakeviz` server was running on. Now we limit what can be viewed to the filename that was passed in on command line. In the future the CLI could be extended to allow browsing a directory of profile files.
|
Let me know if you think this is a good direction. I'm thinking maybe we can change the cli to accept |
|
(It's failing on 2.7, but with py2 going EOL at end of year, maybe not worth supporting it?) |
|
this seems to be available with self._list_dirs already (somewhat broken but I just submitted a pull request that should fix it) |
|
Thanks for submitting this! I don't think I'm quite ready to drop Python 2.7 support yet. Could this also be done with os.path operations? I'm also curious about the motivation for this, are you running into a specific situation in which you want to limit the browsable directory? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously one could browse the whole filesystem on the machine that
snakevizserver was running on. Now we limit what can be viewed to thefilename that was passed in on command line.
In the future the CLI could be extended to allow browsing a directory of
profile files.