Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate song data API #210

Merged
merged 5 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.development
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
VITE_SONGDATA_API_URL=http://localhost:8787/
1 change: 1 addition & 0 deletions .env.production
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
VITE_SONGDATA_API_URL=https://nostatus-songdata-api.c-stellar.net/
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ dev-dist
*.local

.env
.env*.local

# Editor directories and files
.vscode/*
Expand Down
2 changes: 1 addition & 1 deletion biome.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/1.6.3/schema.json",
"$schema": "https://biomejs.dev/schemas/1.9.3/schema.json",
"organizeImports": {
"enabled": true
},
Expand Down
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"virtua": "^0.35.0"
},
"devDependencies": {
"@biomejs/biome": "^1.6.3",
"@biomejs/biome": "^1.9.3",
"@pandacss/dev": "^0.37.2",
"@shadow-panda/preset": "^0.7.1",
"@types/node": "^20.12.5",
Expand All @@ -61,12 +61,8 @@
"date-fns": "^3.2.0",
"i18next-parser": "^8.12.0",
"npm-run-all2": "^6.1.2",
"prettier": "^3.2.5",
"tsx": "^4.7.1",
"typescript": "^5.6.3",
"vite": "^5.2.14"
},
"prettier": {
"printWidth": 120
}
}
97 changes: 47 additions & 50 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions scripts/genBuildId.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import cp from "child_process";
import { format } from "date-fns";
import { writeFileSync } from "fs";
import cp from "node:child_process";
import { writeFileSync } from "node:fs";

process.env.TZ = "Asia/Tokyo";
const timestamp = format(new Date(), "yyyyMMddHHmm");
Expand All @@ -9,4 +9,4 @@ const commitHash = cp.execSync("git rev-parse --short=7 HEAD", { encoding: "utf8
const buildId = `${timestamp}-${commitHash}`;
console.log("Build ID:", buildId);

writeFileSync(".env", `VITE_BUILD_ID=${buildId}`);
writeFileSync(".env.local", `VITE_BUILD_ID=${buildId}`);
7 changes: 3 additions & 4 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,14 @@ export const App = () => {
})}
>
<div className={css({ mr: "auto" })} />
{/* biome-ignore lint/a11y/useKeyWithClickEvents: TODO */}
<div
<button
className={css({ lineHeight: "tight", textAlign: "center", cursor: "pointer" })}
role="button"
type="button"
onClick={handleClickHeader}
>
<h1 className={css({ textStyle: "title" })}>nostatus</h1>
<p className={css({ textStyle: "tagline", color: "text.sub" })}>Have an eye on your friends' status.</p>
</div>
</button>
<div className={css({ ml: "auto" })}>
<Suspense>
<HeaderMenu />
Expand Down
53 changes: 36 additions & 17 deletions src/components/ShareMusicDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { t } from "i18next";
import { atom, useAtomValue, useSetAtom } from "jotai";
import { loadable } from "jotai/utils";
import { useMemo, useState } from "react";
import { getI18n } from "react-i18next";
import type { LangCode } from "../locales/i18n";
import { myMusicStatusAtom, updateMyStatus } from "../states/nostr";
import { button } from "../styles/recipes";
import { useCloseHeaderMenu } from "./HeaderMenu";
Expand All @@ -12,20 +14,36 @@ import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle, DialogT
import { Input } from "./ui/input";
import { Label } from "./ui/label";

type MusicData = {
type SongData = {
url: string;
title?: string;
artists?: string[];
artist?: string;
};

const songwhipProxyUrl = "https://songwhip-proxy.c-stellar.net/";
const langCodeToCountry = (lang: LangCode) => {
switch (lang) {
case "ja":
return "JP";
case "en":
return "US";
default:
return "US";
}
};

const fetchSongData = async (musicLink: string, lang: LangCode): Promise<SongData> => {
const apiUrl = new URL(import.meta.env.VITE_SONGDATA_API_URL);

const fetchMusicData = async (musicLink: string): Promise<MusicData> => {
const resp = await fetch(`${songwhipProxyUrl}?url=${encodeURIComponent(musicLink)}`);
const params = new URLSearchParams();
params.set("url", musicLink);
params.set("country", langCodeToCountry(lang));
apiUrl.search = params.toString();

const resp = await fetch(apiUrl);
if (!resp.ok) {
throw Error("failed to fetch music data");
throw Error("failed to fetch song data");
}
return resp.json() as Promise<MusicData>;
return resp.json() as Promise<SongData>;
};

const musicLinkAtom = atom<string | undefined>(undefined);
Expand All @@ -36,7 +54,7 @@ const musicDataLoadableAtom = loadable(
if (musicLink === undefined) {
return Promise.resolve(undefined);
}
return fetchMusicData(musicLink);
return fetchSongData(musicLink, getI18n().language as LangCode);
}),
);

Expand All @@ -52,16 +70,17 @@ export const ShareMusicDialog: React.FC<ShareMusicDialogProps> = ({ trigger }) =

const [musicLinkInput, setMusicLinkInput] = useState("");
const setMusicLink = useSetAtom(musicLinkAtom);
const musicData = useAtomValue(musicDataLoadableAtom);
const songData = useAtomValue(musicDataLoadableAtom);

const newMusicStatus = useMemo(() => {
if (musicData.state !== "hasData" || musicData.data === undefined) {
if (songData.state !== "hasData" || songData.data === undefined) {
return undefined;
}
return {
content: `${musicData.data.title || "???"} - ${(musicData.data.artists ?? []).join(", ")}`,
linkUrl: musicData.data.url,
content: `${songData.data.title || "???"} - ${songData.data.artist || "???"}`,
linkUrl: songData.data.url,
};
}, [musicData]);
}, [songData]);

const currMusicStatus = useAtomValue(myMusicStatusAtom);

Expand Down Expand Up @@ -124,20 +143,20 @@ export const ShareMusicDialog: React.FC<ShareMusicDialogProps> = ({ trigger }) =
<button
className={css(button.raw({ color: "primary" }), { flexShrink: "0" })}
type="button"
disabled={musicData.state === "loading"}
disabled={songData.state === "loading"}
onClick={() => setMusicLink(musicLinkInput)}
>
{t("getMusicDataButton")}
</button>
</div>

{(musicData.state !== "hasData" || newMusicStatus !== undefined) && (
{(songData.state !== "hasData" || newMusicStatus !== undefined) && (
<p className={css({ textStyle: "dialog-label-like" })}>{t("musicStatusPreview")}</p>
)}
{musicData.state === "loading" && <p>{t("musicDataLoading")}</p>}
{songData.state === "loading" && <p>{t("musicDataLoading")}</p>}
{newMusicStatus !== undefined && <MusicStatusView {...newMusicStatus} />}

{musicData.state === "hasError" && (
{songData.state === "hasError" && (
<p className={css({ fontSize: "sm", color: "destructive.text" })}>{t("fetchingMusicDataFailed")}</p>
)}

Expand Down
9 changes: 0 additions & 9 deletions src/env.d.ts

This file was deleted.

9 changes: 9 additions & 0 deletions src/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
/// <reference types="vite/client" />

interface ImportMetaEnv {
readonly VITE_BUILD_ID: string;
readonly VITE_SONGDATA_API_URL: string;
}

interface ImportMeta {
readonly env: ImportMetaEnv;
}