Add support for CheriBSD #55
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a warning when building for CheriBSD (Morello purecap).
Some systems such as 64-bit CHERI-RISC-V or Arm Morello have 128-bit pointers, so for them the sizeof(event) assertion needs to be updated.
…ents `fcntl()` abuses C variadic arguments to implement optional parameters. We want to forward this argument to the real `fcntl()` call, but doing so is non-portable. On most architectures, we can just read an `intptr_t`/`void*` and this will give us a (semi-)valid result even if no argument/an int was passed instead since `va_arg()` will generally read the next argument register or arbitrary data from the stack. On CHERI-enabled architectures, variadic arguments are tightly bounded, which means that reading a `void*` if an `int` was passed will result in a runtime trap. To avoid this problem this commit uses a new `vfcntl` libc function (CTSRD-CHERI/cheribsd#2194), that takes a va_list instead of variadic arguments. Since this needs a new HAVE_VCNTL compile-time check, this adds a new config.h header that also includes the HAVE_TIMERFD value. This removes the need to pass -D flags on the command line. This reduces the number of test failures on CheriBSD Morello from 210 to 8.
Closed
|
Marking as draft while I work on https://reviews.freebsd.org/D46403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried running the tests on my Morello board and noticed that most of them were failing. This patch series makes epoll-shim work correctly when running on CheriBSD (a fork of FreeBSD that adds support for CHERI-enabled architectures such as CHERI-RISC-V and Arm Morello).
With this patch series all but two tests pass for me and the last remaining failures will go away once CTSRD-CHERI/cheribsd#1424 has been fixed.
This supersedes #36 and all the commits in that PR have been split out into separate changes.
Depends on CTSRD-CHERI/cheribsd#2194