PydanticTwoCompatibility: Handle missing __validators__ #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoanFM
approved these changes
Mar 1, 2024
gabe-l-hart
force-pushed
the
PydanticTwoCompatibility-67
branch
from
61ee4a3 to
9f16c06
Compare
|
Sorry to miss the commit linting standards! Just force-pushed and should be good |
jina-ai#67 Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
force-pushed
the
PydanticTwoCompatibility-67
branch
from
9f16c06 to
c0837a6
Compare
|
One more try with no upper case letters in the commit header! |
|
Thanks, and sorry for the CI flailing! |
No problem, I should relax some requirements actually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67
Goals:
This PR is a partial fix to #67 to allow
create_output_doc_typeto work withpydantic>=2. It does not address the transitive dependency fromjinawhich would require further investigation.