Add support for full RGB colors and TextDecorations #178
Annotations
1 error, 8 warnings, and 10 notices
|
Inspect code
Issues found.
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Inspect code:
src/Consolonia.Core/Drawing/DrawingContextImpl.cs#L146
"[AccessToModifiedClosure] Captured variable is modified in the outer scope" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/DrawingContextImpl.cs(146,69)
|
|
Inspect code:
src/Consolonia.Core/Drawing/DrawingContextImpl.cs#L146
"[AccessToModifiedClosure] Captured variable is modified in the outer scope" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/DrawingContextImpl.cs(146,72)
|
|
Inspect code:
src/Consolonia.Core/Drawing/RenderTarget.cs#L121
"[BadChildStatementIndent] Line indent is not restored to the previous level around child statement" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/RenderTarget.cs(121,1)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L42
"[CompareOfFloatsByEqualityOperator] Equality comparison of floating point numbers. Possible loss of precision while rounding values" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(42,65)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L70
"[CompareOfFloatsByEqualityOperator] Equality comparison of floating point numbers. Possible loss of precision while rounding values" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(70,65)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelForeground.cs#L2
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelForeground.cs(2,1)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L42
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(42,64)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L70
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(70,64)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L88
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(88,20)
|
|
Inspect code:
src/Consolonia.PlatformSupport/WindowsConsole.cs#L166
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/WindowsConsole.cs(166,39)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L72
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(72,25)
|
|
Inspect code:
src/Consolonia.Core/Text/FontManagerImpl.cs#L38
"[ArrangeTrailingCommaInMultilineLists] Remove trailing comma to conform to code style" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Text/FontManagerImpl.cs(38,30)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L73
"[BuiltInTypeReferenceStyle] Built-in type reference is inconsistent with code style settings" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(73,68)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L53
"[BuiltInTypeReferenceStyleForMemberAccess] Built-in type reference is inconsistent with code style settings" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(53,53)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L54
"[BuiltInTypeReferenceStyleForMemberAccess] Built-in type reference is inconsistent with code style settings" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(54,53)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L55
"[BuiltInTypeReferenceStyleForMemberAccess] Built-in type reference is inconsistent with code style settings" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(55,53)
|
Loading