Skip to content

Commit

Permalink
CA1303 disabled (#157)
Browse files Browse the repository at this point in the history
  • Loading branch information
jinek authored Nov 30, 2024
1 parent ad9bc55 commit 13e2b54
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions src/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ dotnet_diagnostic.ca2213.severity = none # keeping field does not mean necessari
dotnet_diagnostic.ca2248.severity = none # https://github.com/dotnet/roslyn-analyzers/issues/4432
dotnet_diagnostic.ca1062.severity = none # we are fine with NRE - no need for additional checks
dotnet_diagnostic.ca1065.severity = none # senseless rules. Any code in .NET is executed in context of possible exceptions. Exception can happen anywhere
dotnet_diagnostic.CA1303.severity = none # we are assuming not to display any user-text. For the moment we are not supporting localization for exception messages
dotnet_diagnostic.cs0067.severity = warning
dotnet_diagnostic.cs0078.severity = warning
dotnet_diagnostic.cs0108.severity = warning
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public class InputLessDefaultNetConsole : IConsole
private bool _caretVisible;
private PixelBufferCoordinate _headBufferPoint;

#pragma warning disable CA1303 // Do not pass literals as localized parameters
protected InputLessDefaultNetConsole()
{
Console.OutputEncoding = Encoding.UTF8;
Expand All @@ -38,7 +37,6 @@ protected InputLessDefaultNetConsole()

ActualizeSize();
}
#pragma warning restore CA1303 // Do not pass literals as localized parameters

protected bool Disposed { get; private set; }

Expand Down Expand Up @@ -143,9 +141,7 @@ public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
#pragma warning disable CA1303 // Do not pass literals as localized parameters
Console.Write(ConsoleUtils.DisableAlternateBuffer);
#pragma warning restore CA1303 // Do not pass literals as localized parameters
}

public void ClearOutput()
Expand Down

0 comments on commit 13e2b54

Please sign in to comment.