-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better landing page #420
Merged
Merged
Better landing page #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Change the writeup to turn the section into a 'Why Jippy' section -Pitching Jippy's features will now be done in a separate Features section
-Highlights the text within <Highlight> tags with Jippy Green(and text turns white) for emphasis
-Displays an Accordion of the features available with a little demo associated with each feature
-Displays a demo of the essay feedback feature
-Displays a demo of the essay helper feature
-Add interfaces that will be used on the new landing page for various sections
-Displays 1 Question-Answer part to put in the FAQ of the landing page
-Split features section into more distinct 'Why Jippy' and 'Features' sections -Add highlighting of specific keywords for emphasis and coolness -Add demo of key features in the new 'Features' section with the new FeatureList component -Add more FAQs and corresponding answers -Refactor some components to use .map() so as to reduce repetitive css class declaration and ease maintenance while improving code readability
-Stop hiding the feature accordion on mobile breakpoints when the feature demo is clicked by stopping propagation of click events
-Add the corresponding essay question to the demo of the essay helper so users can see what question the sample points are for
-Add vertical padding on mobile breakpoints around the feature demo to visually distinguish the demo part from the rest of that section
-Add responsive gap between demo and feature description on the landing page
-Switch from flexbox to grid layout to support flexible sizing of the 'Why Jippy' Cards and auto-wrapping of Cards to the next row -All rows are now the same height, which is not possible with flexbox
-Fix Carousel overflowing parent container width on smaller breakpoints
-Add onClick as a prop of NewsArticle to support custom onClick() events
-Display an interesting article from Jippy's actual database on the landing page features section -Disable onClick for the NewsArticle component on the landing page using the new onClick prop of NewsArticle
-Update number of articles described on the landing page
-Standardise font sizes for headers/subtitles/content text -Standardise gap and margins between elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New 'Features' section with feature demos:
'Features' section now modified into 'Why Jippy' section, with updated look on desktop(no carousel):
More FAQs and accompanied answers: