Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge more landing page improvements #429

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Merge more landing page improvements #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d830fce
Fix margin on large breakpoints
haoyangw Nov 12, 2024
5717af3
Improve landing page feature demo
haoyangw Nov 12, 2024
68ab9d2
Fix typo in essay helper
haoyangw Nov 12, 2024
a4c7d20
Fix landing page spacing
haoyangw Nov 12, 2024
8867c4c
Merge pull request #428 from cs3216-a3-group-4/haoyang/better-landing…
haoyangw Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/app/(authenticated)/answers/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const AnswerPage = ({ params }: { params: { id: string } }) => {
id="answer"
>
<div className="flex flex-col pb-4 mb-4 py-8 xl:py-16 max-w-6xl md:mx-8 lg:mx-16 xl:mx-auto">
<h1 className="px-8 md:px-0 text-2xl lg:text-3x xl:text-4xl font-semibold text-text mb-10 2xl:mb-12">
<h1 className="px-8 md:px-0 text-2xl lg:text-3xl xl:text-4xl font-semibold text-text mb-10 2xl:mb-12">
{data.question}
</h1>
<div className="flex flex-col">
Expand Down
2 changes: 1 addition & 1 deletion frontend/app/landing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ const Landing = () => {
</span>
</div>

<div className="flex-1 md:basis-7/12 p-12 mt-10 bg-background border rounded-lg shadow-lg">
<div className="flex-1 md:basis-7/12 p-12 mt-10 md:mt-0 bg-background border rounded-lg shadow-lg">
<p className="text-xl md:text-2xl lg:text-3xl text-text">
Jippy is after all just an AI frog, and can make mistakes, but
here are some things made sure to train Jippy on to avoid mistakes
Expand Down
6 changes: 3 additions & 3 deletions frontend/components/landing/feature-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ const FeatureList = ({ features }: FeatureListProps) => {
)}
</div>
{selectedFeature === feature && (
<div className="mt-2 max-w-full">
<p className="text-sm lg:text-base text-gray-600 text-wrap">
<div className="max-w-full">
<p className="text-sm lg:text-base text-gray-600 text-wrap py-3">
{feature.description}
</p>
<div
className="mt-4 flex flex-col w-full items-stretch cursor-default py-4 md:hidden"
className="flex flex-col w-full items-stretch cursor-default py-8 md:hidden"
id="mobile-demo"
onClick={(e) => e.stopPropagation()}
>
Expand Down
10 changes: 5 additions & 5 deletions frontend/components/landing/sample-points.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ const SamplePoints = ({
}) => {
return (
<>
<h1 className="px-8 md:px-0 text-2xl lg:text-3x xl:text-4xl font-semibold text-text mb-5 2xl:mb-6">
<h2 className="px-8 md:px-0 text-lg xl:text-xl 2xl:text-2xl font-semibold text-text mb-5 2xl:mb-6">
{question}
</h1>
</h2>
<Accordion className="flex flex-col gap-y-4" type="multiple">
{points.map((point, index) => (
<AccordionItem
Expand All @@ -27,18 +27,18 @@ const SamplePoints = ({
>
<AccordionTrigger
chevronClassName="h-6 w-6 stroke-[2.5] ml-4"
className="text-lg lg:text-xl 2xl:text-2xl text-primary font-medium text-start hover:no-underline pt-4 pb-6"
className="text-primary font-medium text-start hover:no-underline pt-4 pb-6"
>
<div className="flex flex-col">
<div className="flex">
<Chip
className="flex mb-4 w-fit max-w-full 2xl:text-xl"
className="flex mb-4 w-fit max-w-full md:text-lg 2xl:text-xl"
label={point.positive ? "For" : "Against"}
size="lg"
variant={point.positive ? "secondary" : "accent"}
/>
</div>
<span className="inline-block text-primary-900 hover:text-primary-900/80">
<span className="text-base xl:text-lg 2xl:text-xl inline-block text-primary-900 hover:text-primary-900/80">
{point.title}
</span>
</div>
Expand Down
Loading