Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve home page top events UI #48

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Improve home page top events UI #48

merged 10 commits into from
Sep 25, 2024

Conversation

haoyangw
Copy link
Contributor

Changes:

  • Add loading animation while waiting for backend event data
  • Add Jippy logo-based placeholder image to replace previous placeholder event image
  • Add 'Others' category in the frontend so that in the event of invalid category names fetched from backend, frontend handles the error 'gracefully' by displaying the 'Others' category Chip

-Use index parameter of list.map() as the key prop for a list element instead of using the category for the NewsArticle component
-Add an 'Others' Category
-In case an unknown category name is fetched from backend or data fetch failed, display the 'Others' Category chip to fail 'gracefully'
-ArticleLoading component is a pulsing card that can be displayed while events are still being loaded from backend on home page
Remove the ugly 'Loading data...' text and replace it with the new pulsing ArticleLoading cards while top events are still being loaded from backend
-Basically our logo but with dulled colours and flexible height/width
-Rather than display a generic placeholder image, use the new PlaceholderImage component to display our logo whenever an event from the backend has no image URL
-Top events now filters by the categories that the user has chosen, not just by article date and event count
@haoyangw haoyangw merged commit bb920b1 into main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant