Separate go build and gofmt checks. #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry the tests were failing :( They should be green in master now. Can you merge in master and let the tests run again? |
…_gofmt_and_go_build
|
It didn't work. Maybe we should pair and fix this later this week. |
|
Yea, sounds good! :) |
|
also this is a good thing for extraction planned in #176 |
|
just reviewed the failing tests, the problem is not added the new checks in https://travis-ci.org/jish/pre-commit/jobs/32905698#L438: -Available checks : ... go jshint ...
+Available checks : ... go go_build go_fmt jshint ...not sure if anything else changed, @marcosvm it should be enough to modify files listed by: grep -rn "go jshint" test/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request separates go build and gofmt checks and creates a go group with both checks.
Some larger projects that contains packages don't behave so well with the go build check, giving false positives errors.g
\cc @jish