Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses two issues with parsing RPC Methods.
The first issue is an incorrect size of the method.flag during the read. In the master branch it is stated as a Uint16, however it is an Uint32. This is already corrected in the V2 branch. Comments were adjusted to represent the correct memory alignment (also corrected in V2).
The second patch uses the RPC method length as the ending position before continuing parsing the method array. If for some reason the data structure adds any additional information beyond the method.parameters value, it would offset the reads creating invalid parsing of the structure. (This was found while connecting to a Beckhoff 4026.8 host)