Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

set domain for cookies to use base domain #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amrnt
Copy link

@amrnt amrnt commented Aug 5, 2013

No description provided.

@pirkka
Copy link

pirkka commented Aug 14, 2013

Thanks, this helped me to persist user's mobile/desktop choice across different subdomains.

@amrnt
Copy link
Author

amrnt commented Aug 14, 2013

Thank you! I'm looking forward for merging this /cc: @jistr

@jistr
Copy link
Owner

jistr commented Aug 14, 2013

@amrnt Heya, sorry for the delay ;) This looks like a good thing to have. Would you mind writing some specs for it? https://github.com/jistr/mobvious/blob/master/spec/mobvious/strategies/cookie_spec.rb

Also I'd prefer if you could change return unless host !~ to return if host =~, but that's not a blocker.

Looks good :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants