Update useEffect deps

jitendraP-ashutec · Dec 15, 2020 · ef655f7 · ef655f7
1 parent 74e8d36
commit ef655f7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 13 deletions.
diff --git a/lib/msal-react/src/MsalProvider.tsx b/lib/msal-react/src/MsalProvider.tsx
@@ -61,7 +61,7 @@ export function MsalProvider({instance, children}: MsalProviderProps): React.Rea
                 instance.removeEventCallback(callbackId);
             }
         };
-    }, [instance, accounts]);
+    }, [instance, accounts, logger]);
 
     useEffect(() => {
         const callbackId = instance.addEventCallback((message: EventMessage) => {
@@ -119,7 +119,7 @@ export function MsalProvider({instance, children}: MsalProviderProps): React.Rea
                 instance.removeEventCallback(callbackId);
             }
         };
-    }, [instance]);
+    }, [instance, logger]);
 
     const contextValue: IMsalContext = {
         instance,

diff --git a/lib/msal-react/src/hooks/useAccount.ts b/lib/msal-react/src/hooks/useAccount.ts
@@ -32,17 +32,12 @@ function getAccount(instance: IPublicClientApplication, accountIdentifiers: Acco
 }
 
 export function useAccount(accountIdentifiers: AccountIdentifiers): AccountInfo | null {
-    const { instance, inProgress, logger } = useMsal();
+    const { instance, inProgress } = useMsal();
 
     const [account, setAccount] = useState<AccountInfo|null>(null);
 
     useEffect(() => {
         setAccount(getAccount(instance, accountIdentifiers));
-        if (logger.isPiiLoggingEnabled()) {
-            logger.verbosePii(`useAccount - Account state set to ${account}`);
-        } else {
-            logger.verbose("useAccount - Account state set");
-        }
     }, [inProgress, accountIdentifiers, instance]);
 
     return account;

diff --git a/lib/msal-react/src/hooks/useIsAuthenticated.ts b/lib/msal-react/src/hooks/useIsAuthenticated.ts
@@ -18,14 +18,13 @@ function isAuthenticated(allAccounts: AccountIdentifiers[], account: AccountInfo
 }
 
 export function useIsAuthenticated(matchAccount?: AccountIdentifiers): boolean {
-    const { accounts: allAccounts, logger } = useMsal();
+    const { accounts: allAccounts } = useMsal();
     const account = useAccount(matchAccount || {});
 
     const [hasAuthenticated, setHasAuthenticated] = useState<boolean>(false);
 
     useEffect(() => {
         setHasAuthenticated(isAuthenticated(allAccounts, account, matchAccount));
-        logger.verbose(`useIsAuthenticated - isAuthenticated state set to ${hasAuthenticated}`);
     }, [allAccounts, account, matchAccount]);
 
     return hasAuthenticated;

diff --git a/lib/msal-react/src/hooks/useMsalAuthentication.ts b/lib/msal-react/src/hooks/useMsalAuthentication.ts
@@ -43,7 +43,7 @@ export function useMsalAuthentication(
             default:
                 throw "Invalid interaction type provided.";
         }
-    }, [instance, interactionType, authenticationRequest]);
+    }, [instance, interactionType, authenticationRequest, logger]);
 
     useEffect(() => {
         const callbackId = instance.addEventCallback((message: EventMessage) => {
@@ -70,7 +70,7 @@ export function useMsalAuthentication(
                 instance.removeEventCallback(callbackId);
             }
         };
-    }, [instance]);
+    }, [instance, logger]);
 
     useEffect(() => {
         if (!hasBeenCalled && !isAuthenticated && inProgress === InteractionStatus.None) {
@@ -82,7 +82,7 @@ export function useMsalAuthentication(
                 return;
             });
         }
-    }, [isAuthenticated, inProgress, hasBeenCalled, login]);
+    }, [isAuthenticated, inProgress, hasBeenCalled, login, logger]);
 
     return { login, result, error };
 }