Skip to content

Commit

Permalink
Always use JVB's podIP as Server ID
Browse files Browse the repository at this point in the history
This way we no longer depend on having Colibri WS port exposed through a service
and instead allow `web` container to access all JVB instances simultaneously.\

As a side-effect, JVB service now works with LoadBalancer and NodePort setups.
Fixes #50.
  • Loading branch information
spijet committed Dec 9, 2022
1 parent 73d6143 commit c9b108c
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 25 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ Parameter | Description | Default
`enableAuth` | Enable authentication | `false`
`enableGuests` | Enable guest access | `true`
`websockets.colibri.enabled` | Enable WebSocket support for JVB/Colibri | `false`
`websockets.colibri.serverID` | Set JVB/Colibri WS Server ID | `podIP` (see `values.yaml`)
`websockets.xmpp.enabled` | Enable WebSocket support for Prosody/XMPP | `false`
`jibri.enabled` | Enable Jibri service | `false`
`jibri.persistence.enabled` | Enable persistent storage for Jibri recordings | `false`
Expand Down
13 changes: 1 addition & 12 deletions templates/jvb/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- $serverID := default "podIP" .Values.websockets.colibri.serverID }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -75,21 +74,11 @@ spec:
fieldPath: status.hostIP
{{- end }}
{{- end }}
{{- if or .Values.websockets.colibri.enabled }}
{{- if .Values.websockets.colibri.enabled }}
- name: JVB_WS_SERVER_ID
{{- if eq $serverID "service" }}
{{- if .Values.global.clusterDomain }}
value: {{ include "jitsi-meet.jvb.fullname" . }}.{{ .Release.Namespace }}.svc.{{ .Values.global.clusterDomain }}
{{- else }}
value: {{ include "jitsi-meet.jvb.fullname" . }}.{{ .Release.Namespace }}.svc
{{- end }}
{{- else if eq $serverID "podIP" }}
valueFrom:
fieldRef:
fieldPath: status.podIP
{{- else }}
value: {{ $serverID | quote }}
{{- end }}
{{- end }}
{{- if .Values.octo.enabled }}
- name: JVB_OCTO_BIND_ADDRESS
Expand Down
5 changes: 0 additions & 5 deletions templates/jvb/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ spec:
{{- end }}
protocol: UDP
name: rtp-udp
{{- if or .Values.websockets.colibri.enabled }}
- port: 9090
protocol: TCP
name: colibri-ws-tcp
{{- end }}
{{- with .Values.jvb.service.externalIPs }}
externalIPs:
{{ toYaml . | indent 2 | trim }}
Expand Down
7 changes: 0 additions & 7 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@ websockets:
## Colibri (JVB signalling):
colibri:
enabled: false
## Uncomment this to set JVB server ID manually,
## Or use one of pre-defined values:
## * "podIP" will fetch JVB pod's IP address from K8s metadata;
## * "service" will use JVB service name generated by Helm.
##
## (default is "podIP")
# serverID: podIP
## XMPP (Prosody signalling):
xmpp:
enabled: false
Expand Down

0 comments on commit c9b108c

Please sign in to comment.