Introduce DESKTOP_SHARING_FRAMERATE_AUTO to allow browser to determine sharing fps automatically #1674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #1668
The docker containers allow the option to set the screen sharing fps via two environment variables
DESKTOP_SHARING_FRAMERATE_MIN
andDESKTOP_SHARING_FRAMERATE_MAX
. This is fine for people who want to tweak these settings, but on meet.jit.si, these options are left to the defaults. These are that min and max framerate are not configured at all, and that they are therefore left to the browser to determine.This PR introduces a new environment variable
DESKTOP_SHARING_FRAMERATE_AUTO
which when set totrue
, which is the default, does not configure the desktop sharing parameters in theweb
container at all, i.e. leaving them up to the browser to determine (which is also the behaviour on meet.jit.si). For those who still want to configure their own framerate, they can setDESKTOP_SHARING_FRAMERATE_AUTO
tofalse
and configureDESKTOP_SHARING_FRAMERATE_MIN
andDESKTOP_SHARING_FRAMERATE_MAX
as they wish.