sdk(react-native-sdk): added some dependencies to peer dependencies #13498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should only put React-native related packages as peer deps, the rest can be normal deps. AFAIK we need to do it that way so automatic linking works on the app using our SDK. |
Calinteodor
force-pushed
the
rnsdk-peer-dependencies
branch
from
37a73a7
to
9f82f73
Compare
saghul
approved these changes
Jun 30, 2023
hristoterezov
pushed a commit
that referenced
this pull request
Jul 19, 2023
…13498) * sdk(react-native-sdk): moved some dependencies to peer dependencies react-native-community/cli#870 https://github.com/callstack/react-native-builder-bob#how-do-i-add-a-react-native-library-containing-native-code-as-a-dependency-in-my-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps that will use React Native SDK will depend on these peer deps.