fix(config): Remove the deprecated configs. #13500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the new codec selection settings for desktop and mobile endpoints.
jallamsetty1
force-pushed
the
feat-multiple-codecs
branch
from
5250288
to
042936a
Compare
saghul
reviewed
Jun 28, 2023
| @@ -47,13 +47,11 @@ const INITIAL_RN_STATE: IConfig = { | |||
| // FIXME: than requiring this override here... | |||
|
|
|||
| p2p: { | |||
| disabledCodec: 'vp9', | |||
| preferredCodec: 'h264' | |||
| mobileCodecPreferenceOrder: [ 'H264', 'VP8' ] | |||
There was a problem hiding this comment.
What the value if we don't define this? We could make the code behave like so, and remove this override entirely, and people can configure whatever they want in config.js, no?
There was a problem hiding this comment.
https://github.com/jitsi/lib-jitsi-meet/pull/2296/files#diff-dcb81f0be0b559eee3d7693e162f67f90eee41d6fa0a8cbc91c6460ec02f5c36R38 will be the new default order which is applicable to desktop clients. We could define a different set for mobile endpoints by default.
|
Other PRs seem to pass. Are we sure the failures are not related? |
|
MuteTest on Firefox has been failing on alpha for few weeks now so that one is unrelated for sure. |
jallamsetty1
force-pushed
the
feat-multiple-codecs
branch
from
741fa17
to
9fc097b
Compare
saghul
approved these changes
Jul 3, 2023
hristoterezov
pushed a commit
that referenced
this pull request
Jul 19, 2023
* fix(config): Remove the deprecated configs. Add the new codec selection settings for desktop and mobile endpoints. * fix(config): Use the new codec selection settings for RN. * Address review comments. * chore(deps) Update lib-jitsi-meet@latest. jitsi/lib-jitsi-meet@v1649.0.0+17ade96a...v1652.0.0+90da4884.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new codec selection settings for desktop and mobile endpoints.