ref(toolbar) Move getButtons to functions #13502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move visible logic inside each button Move click functionality inside each button Extract getButtons function from Toolbox components to functions file
|
I don't think the failing test is related to these changes. I see it fail on other PRs. |
Calinteodor
approved these changes
Jun 29, 2023
hristoterezov
pushed a commit
that referenced
this pull request
Jul 19, 2023
Move visible logic inside each button Move click functionality inside each button Extract getButtons function from Toolbox components to functions file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move visibility logic inside each button
Move click functionality inside each button
Extract getButtons function from Toolbox components to functions file