feat(external-api) add command for setting camera facing mode #13541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
horymury
commented
Jul 7, 2023
•
horymury
commented
- added command for setting the camera facing mode remotely
- enhanced toggleVideo command to optionally accept the facing mode
- fix startSilent asking for microphone permissions.
horymury
force-pushed
the
hmuresan/camera-capture-commands
branch
from
99cbbdb
to
ef33d5a
Compare
horymury
force-pushed
the
hmuresan/camera-capture-commands
branch
from
2baf822
to
bce8c56
Compare
horymury
force-pushed
the
hmuresan/camera-capture-commands
branch
from
bce8c56
to
c3f72ea
Compare
horymury
changed the title
horymury
changed the title
saghul
approved these changes
Aug 15, 2023
saghul
requested changes
Aug 15, 2023
- added command for setting the camera facing mode remotely - enhanced toggleVideo command to optionally accept the facing mode
horymury
force-pushed
the
hmuresan/camera-capture-commands
branch
from
f6154f6
to
35ea879
Compare
saghul
approved these changes
Aug 16, 2023
|
Please Jenkins test this please |
|
The grid is broken, I'm working on fixing it. I will rerun all failed tests when it is healthy. |
|
Looks like this is ready to go @horymury ! 🚀 |
horymury
added a commit
that referenced
this pull request
Aug 18, 2023
- added command for setting the camera facing mode remotely - enhanced toggleVideo command to optionally accept the facing mode - fix(startSilent) do not create audio track when start silent
horymury
added a commit
that referenced
this pull request
Aug 18, 2023
- added command for setting the camera facing mode remotely - enhanced toggleVideo command to optionally accept the facing mode - fix(startSilent) do not create audio track when start silent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.