#13480 🐛 solved the flip bug in screen share video #13542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
damencho
reviewed
Jul 7, 2023
| @@ -497,7 +497,7 @@ export class VideoContainer extends LargeContainer { | |||
|
|
|||
| const flipX = stream.isLocal() && this.localFlipX && !this.isScreenSharing(); | |||
|
|
|||
| this.video.style.transform = flipX ? 'scaleX(-1)' : 'none'; | |||
| this.video.style.transform = flipX && !this.isScreenSharing() ? 'scaleX(-1)' : 'none'; | |||
There was a problem hiding this comment.
Hum, but !this.isScreenSharing() is taken into account two lines above? I don't see the change with this PR?
There was a problem hiding this comment.
@damencho Sorry for the previous mistake, I just updated the pull request
Thanks in advanced
|
The change LGTM now. |
saghul
approved these changes
Jul 7, 2023
|
Jenkins test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the screen share in which after changing the virtual background the screen share video tag had a scale with a -1 value, I edited this and added the
!isScreenShare()condition before it. Now the issue doesn't exists anymore :)