sdk(react-native-sdk): error fixes #13549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
requested changes
Jul 11, 2023
| @@ -74,8 +74,11 @@ function _setAppStateListenerF({ getState }: IStore, next: Function, action: Any | |||
| const result = next(action); | |||
| const { appStateListener: newListener } = getState()['features/background']; | |||
|
|
|||
| // @ts-ignore | |||
| const appStateOldListener = AppState.addEventListener('change', oldListener); | |||
There was a problem hiding this comment.
This won't remove the previous listener. We need to store the return value of AppState.addEventListener and place that in redux.
There was a problem hiding this comment.
I created an action(eventSubcription) that stores the previous appStateListener.
|
You can simplify things by storing only the subscription and not the listener. |
Calinteodor
force-pushed
the
rnsdk-error-fixes
branch
from
fcc51a0
to
06237ef
Compare
|
Can you pl rename things along the lines of _SET_APP_STATE_SUBSCRIPTION then? _ means it's a private action |
saghul
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.