Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable: automatical send funtion by clicking 'enter' in feedback #14515

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

chizhangWang
Copy link
Contributor

Ich sage:If the user enters a longer text and then moves to the right to the end of the input area, then the user uses the key for the next input. However, this always leads to the feedback being sentfeedback (and therefore to an incomplete description)
I fixed the code. It will not define a default button that is triggered by Return. The user should always explicitly click on the button to submit their rating.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Mar 21, 2024

In a dialog which takes used input in the form of text a "return to send" functionality is almost a given.

@chizhangWang
Copy link
Contributor Author

I didn't fixed the return thing for dialog, i did it for the feedback text. In the dialog everything works as before.

@chizhangWang chizhangWang changed the title disable: automatical send funtion by clicking 'enter' disable: automatical send funtion by clicking 'enter' in feedback Mar 21, 2024
@saghul
Copy link
Member

saghul commented Mar 21, 2024

But the text is part of the dialog isn't it?

@chizhangWang
Copy link
Contributor Author

I think it's not a part of dialog. I suppose the dialog is the chat part, where the participants can type thing and communicate. But the feedback text is in feedback window, people type in and click 'ok', then send to feedback backend.

The feedback window gives a large field for typing in feedback text. When users type in long sentence and click return for switch to another line, feedback is automatically sent. It makes user confused.

In code the feedback text is in the file FeedbackDialog.web.tsx and is defined by dialog structure. That is true.

@saghul
Copy link
Member

saghul commented Mar 21, 2024

Ah, I get it now. You're right.

@damencho
Copy link
Member

jenkins test this please.

@saghul saghul merged commit 6db0f89 into jitsi:master Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants