feat(next speaker notification) #14904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
liumengyuan1997
force-pushed
the
next-speaker-notification
branch
from
108008b
to
3e09b0c
Compare
liumengyuan1997
force-pushed
the
next-speaker-notification
branch
3 times, most recently
from
8a74a71
to
0fd660f
Compare
liumengyuan1997
commented
Jul 18, 2024
liumengyuan1997
commented
Jul 18, 2024
liumengyuan1997
commented
Jul 18, 2024
liumengyuan1997
commented
Jul 18, 2024
liumengyuan1997
force-pushed
the
next-speaker-notification
branch
from
7e4e79a
to
3d4918e
Compare
liumengyuan1997
commented
Jul 23, 2024
liumengyuan1997
commented
Jul 23, 2024
liumengyuan1997
commented
Jul 23, 2024
liumengyuan1997
commented
Jul 23, 2024
liumengyuan1997
commented
Jul 23, 2024
liumengyuan1997
force-pushed
the
next-speaker-notification
branch
from
adee0df
to
2937093
Compare
saghul
reviewed
Jul 24, 2024
| case NOTIFIED_TO_SPEAK: { | ||
| return { | ||
| ...state, | ||
| raisedHandsQueue: state.raisedHandsQueue.map((item, index) => { |
| ...state, | ||
| raisedHandsQueue: state.raisedHandsQueue.map((item, index) => { | ||
| if (index === 0) { | ||
| return { ...item, |
There was a problem hiding this comment.
You don't need to clone the item entirely, since we only depend on the queue being unique, but it won't hurt either.
liumengyuan1997
force-pushed
the
next-speaker-notification
branch
from
2937093
to
2acee8b
Compare
|
Hi Saghul @saghul, I have completed the code updates. Please let me know if any further actions are required. Thanks! |
mihhu
reviewed
Jul 30, 2024
| export function hasBeenNotified(state: IReduxState): boolean { | ||
| const raisedHandsQueue = state['features/base/participants'].raisedHandsQueue; | ||
|
|
||
| return Boolean(raisedHandsQueue[0].hasBeenNotified); |
There was a problem hiding this comment.
I would check here if the first element exists, like you did above with the optional chaining operator, otherwise it would throw an error
liumengyuan1997
force-pushed
the
next-speaker-notification
branch
from
2acee8b
to
cc15ba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi reviewer,
This pull request added the next speaker notification feature to the web application. However, the variable naming is a problem. If you have good ideas about the naming, please let me know.