feat(shared-video): Shows confirmation dialog before playing video. #15059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
force-pushed
the
play-video-confirm2
branch
from
ee57d5a
to
c499af6
Compare
Calinteodor
force-pushed
the
play-video-confirm2
branch
from
7eb45b0
to
2f28698
Compare
Calinteodor
force-pushed
the
play-video-confirm2
branch
from
c607f54
to
0fc9a17
Compare
damencho
force-pushed
the
play-video-confirm2
branch
from
9572aaa
to
79ffd02
Compare
hristoterezov
approved these changes
Aug 27, 2024
damencho
added a commit
that referenced
this pull request
Aug 27, 2024
…15059) * feat(shared-video): Shows confirmation dialog before playing video. * feat(shared-video/native): created ShareVideoConfirmDialog and unified actions * squash: Simplifies state and fixes stop and then start scenario. * squash: Use constants everywhere. * squash: Use helper function. * squash: Ignore any command with not matching video URL. --------- Co-authored-by: Calin-Teodor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.