Accessibility: keyboard navigation on the toolbar (Context menu) #15060
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix ResizeObserver loop issue
|
Hi, thanks for your contribution! |
|
@saghul is there any update on this PR? |
|
Jenkins please test this please. |
Calinteodor
reviewed
Sep 16, 2024
| @@ -44,6 +44,24 @@ interface IProps { | |||
| targetSelector?: string; | |||
| } | |||
|
|
|||
| /** | |||
| * Utility function to debounce the execution of a callback function. | |||
There was a problem hiding this comment.
@ahmadkadri Can you move this helper into functions.any and export it from there?
This might be useful in other cases.
|
Jenkins test this please. |
Calinteodor
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When user use the keyboard navigation and open video or audio settings under menu the focus should move and stay in the under menu till the under menu closed.
Actual Behavior:
1- After opening the menu using keyboard navigation, user have navigate with tap on all toolbar buttons to reach it.
2- The keyboard focus with tap move to other elements (buttons) even if the menu is open.
3- If the menu is open and the focus on other element press ESC doesn't close it.
Expected Behavior:
1- After opening the menu using keyboard navigation, the focus should move directly to the menu.
2- The focus should stay in inside the menu.
3- By clicking ESC closed the menu and move the focus back to the button.
Before:
beforeUnderMenuInToolbar.mp4
After:
ahterUnderMenuInToolbar.mp4
issue jitsi community: https://community.jitsi.org/t/accessibility-keyboard-navigation/133334
NOTE: This PR included the fix of "ResizeObserver loop completed with undelivered notifications". This error typically occurs when the ResizeObserver detects changes in element sizes and tries to update the layout, but the changes trigger more layout recalculations than the browser can handle in a single event loop cycle. Browsers like Chrome trigger this error as a warning and not necessarily because something is broken.