shared video local participant #15086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
damencho
commented
Sep 3, 2024
damencho
commented
- feat(participants-pane): Fixes actions menu when sharing video.
- feat(shared-video): Fixes showing thumb on the sharer side.
We have actions menu for the video just for the local participant who shared the video.
| @@ -146,3 +148,31 @@ export function isURLAllowedForSharedVideo(url: string, | |||
|
|
|||
| return false; | |||
| } | |||
|
|
|||
| /* eslint-disable max-params */ | |||
There was a problem hiding this comment.
Do we need this?
The parameter is 1. Isn't it?
There was a problem hiding this comment.
I moved it with the command, seems someone forgot to remove it at some point.
damencho
force-pushed
the
shared-video-local-participant
branch
from
f59a283
to
c3f8b76
Compare
hristoterezov
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.