fix(jwt): Use isJwtFeatureEnabled the same way in all places. #15162
+38
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where we were showing cc button for visitors that does not have features in the token.
damencho
force-pushed
the
jwt-features-update
branch
from
d5f76be
to
7b61dab
Compare
By default, that feature is disabled.
damencho
force-pushed
the
jwt-features-update
branch
from
7b61dab
to
15579c3
Compare
| if (typeof features === 'undefined') { | ||
| return true; | ||
| return ifNoToken; |
There was a problem hiding this comment.
I'm wondering shouldn't we return ifNotInFeatures in this use case?
There was a problem hiding this comment.
Well when there are no features, we want to respect isModerator, which we pass to ifNoToken.
damencho
force-pushed
the
jwt-features-update
branch
from
daae560
to
f0753a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where we were showing cc button for visitors that does not have features in the token.