Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented down stuff #15169

Closed
wants to merge 1 commit into from
Closed

commented down stuff #15169

wants to merge 1 commit into from

Conversation

hxrshxz
Copy link

@hxrshxz hxrshxz commented Oct 2, 2024

It was supposed to be a part of the documentation it seems but wasn't commented so I solved that issue

It was supposed to be a part of the documentation it seems but wasn't commented so I solved that issue
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@hxrshxz
Copy link
Author

hxrshxz commented Oct 2, 2024

done, kindly review my PR now

@damencho damencho closed this Oct 2, 2024
@damencho damencho reopened this Oct 2, 2024
@damencho
Copy link
Member

damencho commented Oct 2, 2024

Can you explain more, what is not in the documentation and why are you commenting this?

@hxrshxz hxrshxz closed this Oct 2, 2024
@hxrshxz hxrshxz reopened this Oct 2, 2024
@damencho
Copy link
Member

damencho commented Oct 2, 2024

image

@damencho
Copy link
Member

damencho commented Oct 2, 2024

Everything looks as expected. So this change will remove the last entry which we do not want to do.

@damencho damencho closed this Oct 2, 2024
@hxrshxz
Copy link
Author

hxrshxz commented Oct 2, 2024

ok my apologies

@hxrshxz
Copy link
Author

hxrshxz commented Oct 2, 2024

i am new here so can u suggest me some good first issues

@hxrshxz hxrshxz deleted the patch-1 branch October 2, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants