Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added heart reaction feature #15291

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Added heart reaction feature #15291

merged 5 commits into from
Nov 13, 2024

Conversation

KingRain
Copy link
Contributor

Closes #15211

Added the heart reaction icon to the Reaction pane and also the necessary audio files for the reaction.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho
Copy link
Member

What is the origin of the sound files?

@KingRain
Copy link
Contributor Author

What is the origin of the sound files?

They are from https://uppbeat.io/ made by Epic Stock Media

saghul
saghul previously approved these changes Nov 12, 2024
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (untested though)

@damencho
Copy link
Member

Drop the last commit, it is not relevant to this feature.

Copy link
Member

@aaronkvanmeerten aaronkvanmeerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also didn't test)

@damencho
Copy link
Member

jenkins test this please.

Copy link
Member

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not looking good, it used to be one line ...
image
Also, it is missing the tooltip text:
image

Other than that LGTM.

@damencho
Copy link
Member

jenkins test this please.

@damencho damencho merged commit 71de1d1 into jitsi:master Nov 13, 2024
9 checks passed
@damencho
Copy link
Member

Cheers! Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Heart Reaction 💖
5 participants