Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Aligned Words List Output #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qiisziilbash
Copy link

Sometimes one needs to get lists of aligned words from the given sentences.

This PR extracts that logic from _construct_comparison_string into get_alignment_words and exposes it publicly to be used when one needs to process aligned words.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@nikvaessen
Copy link
Collaborator

Why not simply extract them from https://jitsi.github.io/jiwer/reference/process/#process.WordOutput?

@qiisziilbash
Copy link
Author

qiisziilbash commented Oct 17, 2024

Why not simply extract them from https://jitsi.github.io/jiwer/reference/process/#process.WordOutput?

I might be missing something; but the input for the function I added (i.e. get_alignment_words) is the process.WordOutput, no? So I am using that to make these list. Also logic for get_alignment_words was already in the _construct_comparison_string; I just broke it to its own function that can be used publicly/separately as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants