-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watchRTC as a feature for Jitsi meet #2311
Conversation
Hi, thanks for your contribution! |
modules/watchRTC/WatchRTC.ts
Outdated
return; | ||
} | ||
|
||
// watchRTC "proxies" WebRTC functions such as GUM and RTCPeerConnection by rewriting the global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer the case. We used to store window.PeerConnection
but we no longer do. Or did we miss a spot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand. Is this about the verbose comment written and behaviour of the lib jitsi meet written within the comment ?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's about the comment.
package.json
Outdated
@@ -20,6 +20,7 @@ | |||
"@jitsi/logger": "2.0.0", | |||
"@jitsi/sdp-interop": "git+https://github.com/jitsi/sdp-interop#3d49eb4aa26863a3f8d32d7581cdb4321244266b", | |||
"@jitsi/sdp-simulcast": "0.4.0", | |||
"@testrtc/watchrtc-sdk": "^1.36.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the exact version, aka, leave ^ out.
Please see the test failure, we are going to need to bump the library size. |
@saghul , I have tried to address all review points. Please let me know your feedback. |
The test failures seem legit. I think we should gate starting of watchRTC if it's not enabled or no room name was provided. |
I believe the failure should resolve now. For context, there are checks to see if watchRTC is enabled or not. The idea is to use the roomName and/or peerName from the watchRTC config and if not supplied, we can use what jitsi provides. If we get nothing from jitsi too, watchRTC SDK would handle it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @andrei-gavrilescu can you PTAL too?
Looks good 👍 |
@subhamcyara Can you please rebase? Looks like there is some small conflict. Once solved it's good to merge. |
Hi, thanks for the review here. I believe we might also need to take a look at jitsi/jitsi-meet#13527 for changes related to JM. |
Jenkins please test this please. |
Following PR contains changes required to add watchRTC as a module within lib jitsi meet
This involves adding
-- watchRTC is enabled
-- rtcstats must be disabled
-- analytics should be enabled
-- third party requests are not disabled