Skip to content

A legacy refactor kata, focused on the violation of the tell don't ask principle and anemic domain model

License

Notifications You must be signed in to change notification settings

jitterted/toward-domain-exercise

 
 

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

27 Commits
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

"Tell, Don't Ask" Exercise

This was forked from https://github.com/racingDeveloper/tell-dont-ask-kata -- @racingDeveloper on Twitter.

I've updated JUnit to the JUnit 5, and replaced Hamcrest, etc. with AssertJ assertions.

Also replaced references to "kata" to be "exercise"

A legacy refactor exercise, focused on the violation of Andy Hunt's tell don't ask heuristic (also see Fowler) principle and the anemic domain model.

Instructions

Here you find a simple order flow application. It's able to create orders, do some calculations (totals and taxes), and manage them (approve/reject and ship).

The old development team did not find the time to build a proper domain model, but instead preferred to use a procedural style, building this anemic domain model. Fortunately, they did at least take the time to write unit tests for the code.

Your new CTO, after many bugs caused by this application, asked you to refactor this code to make it more maintainable and reliable.

What to focus on

As the title of the exercise says, of course, the tell don't ask principle. You should be able to remove all the setters moving the behavior into the domain objects (Feature Envy perhaps?).

But don't stop there.

If you can remove some test cases because they don't make sense anymore (e.g.: you cannot compile the code to do the wrong thing) feel free to do it!

Contribute

If you would like to contribute to this exercise adding new cases or smells: please open a pull request!

Feedback

Feedback is welcome!

How did you find the exercise? Did you learn anything from it?

Please contact me on Twitter @JitterTed or use the GitHub repo wiki!

About

A legacy refactor kata, focused on the violation of the tell don't ask principle and anemic domain model

Resources

License

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published

Languages

  • Java 100.0%