-
Notifications
You must be signed in to change notification settings - Fork 451
cli: duplicate: add setting for templating the new commit descriptions #6303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could probably use a mention in the Git command table at the very least (if we decide to keep this as a flag and not a setting a la |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluding the efficiency of writing 2x the commits with this option enabled, the main downside of this method is that the evolog looks ugly with the extra commit (IMO):
○ yostqsxw [email protected] 2001-02-03 08:05:15 4037fb05
│ a
○ yostqsxw hidden [email protected] 2001-02-03 08:05:15 3d341b2f
│ a
○ rlvkpnrz [email protected] 2001-02-03 08:05:09 a 2443ea76
│ a
○ rlvkpnrz hidden [email protected] 2001-02-03 08:05:08 d8d5f980
(empty) a
However, the op log looks good. :)
@ 44a208b90324 [email protected] 2001-02-03 04:05:15.000 +07:00 - 2001-02-03 04:05:15.000 +07:00
│ duplicate 1 commit(s)
│ args: jj duplicate a -T 'concat(description, "\n", "(cherry-picked from ", commit_id, ")")'
│
│ Changed commits:
│ ○ + yostqsxw 4037fb05 a
Probably not that big of a deal, though; our working copy snapshots put more "wear" on the repo than this ever could.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation generally looks good to me, thanks.
9d24ab3
to
3f3d1cf
Compare
3f3d1cf
to
a077c6c
Compare
a077c6c
to
985330a
Compare
985330a
to
73cd8c8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
73cd8c8
to
76df180
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
76df180
to
e80f723
Compare
e80f723
to
af9cda6
Compare
Alright, this should be good to go now; would appreciate one more review pass. Thanks for the help! |
af9cda6
to
7af06ee
Compare
7af06ee
to
d731c9c
Compare
This allows the customization of the duplicated commit descriptions. An ideal use case for this is emulating `git cherry-pick -x`, as illustrated in the tests.
d731c9c
to
0910a42
Compare
This allows the customization of the duplicated commit descriptions.
An ideal use case for this is emulating
git cherry-pick -x
, as illustrated in the tests.Checklist
If applicable:
CHANGELOG.md