Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Chrome Extension OAuth2 Library by Juan Ramirez (whoisjuan) #3

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

whoisjuan
Copy link

@whoisjuan whoisjuan commented Jan 15, 2017

This is an update to this awesome and so much needed library.

I struggled a lot to find a reasonable solution for OAuth flows from Chrome Extensions and this was the only good solution I found. Everything else out there is cumbersome and hard to use.

I did four main changes:

  1. I changed the storage from LocalStorage to the Chrome.Storage API.
  2. I updated a Regex that did an extraction from the authorization response. I replaced it with a JSON parsing.
  3. I updated all the documentation with extra explanations on how to setup the library, how to initialize the library and high-level overview of the library.
  4. I took the liberty of doing some branding to the library. It would make it more appealing to other developers. I hope that's ok.

Thanks for creating this little awesome library! I would try to add more contributions!

Cheers,
Juan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant