Created spinsolve.py #147
Merged
Created spinsolve.py #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created the read and guess_udic for spinsolve data, as mentioned in issue #146. The read function will work on a directory and a filename can be specified, otherwise the standard names are tried. When I compared to other fileio scripts I realized that I put everything into one function instead of using smaller functions. I can still do this for a next iteration. I also use the fileio/jcampdx.py script here to read the (optional) .dx file, I'm not sure if that is preferred or if it's better to copy (only) the necessary code here. guess_udic uses acqu.par file parameters (should be always present), otherwise the .dx file header parameters are used (only when using the .dx file)
Updated to include fileio/spinsolv.py
|
I seem to have made a bit of a mess in the commits and can't find how to fix it. I wanted to change 'fileio/init.py', but somehow it happened twice. Therefore "0659e70" can be ignored. Also, find test data attached here (supplied by @NichVC) |
|
This looks really good! Give me a couple of days for testing different datasets and I think this should be ready for a quick merge. Thanks! |
|
This works as expected, and is now merged. Thanks!
|
|
Thanks @kaustubhmote! I'll find some time in the next weeks for your suggestions. |
j-brady
pushed a commit
to j-brady/nmrglue
that referenced
this pull request
Sep 12, 2021
A new "ng.spinsolve" module to read data in spinsolve format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the read and guess_udic for spinsolve data, as mentioned in issue #146.
The read function will work on a directory and a filename can be specified, otherwise the standard names are tried.
When I compared to other fileio scripts I realized that I put everything into one function instead of using smaller functions. I can still do this for a next iteration.
I also use the fileio/jcampdx.py script here to read the (optional) .dx file, I'm not sure if that is preferred or if it's better to copy (only) the necessary code here.
guess_udic uses acqu.par file parameters (should be always present), otherwise the .dx file header parameters are used (only when having a .dx file)