This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
automatic merge? #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if (good_jet_p4s.at(vqqjet_idxs.first).pt() > good_jet_p4s.at(vqqjet_idxs.first).pt()) fixing the typo which makes this condition always true
fixing the typo which makes this condition always true ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
jkguiang
reviewed
Jul 24, 2023
There was a problem hiding this comment.
I would prefer not to merge this into the main branch. You can keep this change separate for now.
jkguiang
reviewed
Jul 24, 2023
There was a problem hiding this comment.
Sorry in advance for the pedantic review: the comment you changed was indeed wrong, but the change is confusing; I think it should read "Sort the two Vqq jets into leading/trailing".
Otherwise, good catch! Glad you are looking at the code closely.
There was a problem hiding this comment.
yeah sorry for the confusing comment.
This code analyze vvh semi merged channel on gen level. H-bb and H-non bb branches were created. ld and tr branches were created for the bb and non_bb. for the v bosons: Branches for the leading and trailing V were created and then branches for the leading and trailing fermions, coming from each V, were created. The two vbf quarks were identified (ld and tr branches). At the end branches like gen_ld_v_mass were created to get the compined kinamatics of the V,and H bossons decay prodcutcs.
Committed out if (jet_idx == ld_vbsjet_idx || jet_idx == tr_vbsjet_idx) { continue; }
as i am going to choose the vqq jets first and then the vbf jets
added the lines:
// Skip Vqq jets candidates
if (jet_i == ld_vqqjet_idx || jet_i == tr_vqqjet_idx) { continue; }
as i chose the vqq jets first, then i need to exclude them while choosing the vbf quarks.
Note: I did this instead of the opposite since i found out that it leads to get results for identifying the vqq jets
selecting the vqq jets first then the vbf jets
// save vbf jet globals to be used in vbs part
// getting the vqq globals to use it to skip vqq jets candidates
int ld_vqqjet_idx = globals.getVal<int>("ld_vqqjet_idx");
int tr_vqqjet_idx = globals.getVal<int>("tr_vqqjet_idx");
// vvhqq globals
cutflow.globals.newVar<int>("ld_vqqjet_idx");
cutflow.globals.newVar<int>("tr_vqqjet_idx");
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.