Skip to content

Commit

Permalink
Do not use cache when building containers in GitHub workflow (#infra)
Browse files Browse the repository at this point in the history
We are setting CONTAINER_BUILD_ARGS env variable in Fedora which was also
brought here. The problem is that CONTAINER_BUILD_ARGS are also Makefile
variable so instead of having the default value which is "--no-cache" we will
set an empty string which will enable the cache back.

We don't use this env variable on RHEL so it's safe for removal.
  • Loading branch information
jkonecny12 committed May 20, 2021
1 parent c14167a commit 0807e0c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
ci_tag: 'rhel-9'
env:
CI_TAG: '${{ matrix.ci_tag }}'
CONTAINER_BUILD_ARGS: '${{ matrix.build-args }}'
TARGET_BRANCH_NAME: 'origin/${{ matrix.target_branch }}'

steps:
Expand Down Expand Up @@ -73,7 +72,6 @@ jobs:
ci_tag: 'rhel-9'
env:
CI_TAG: '${{ matrix.ci_tag }}'
CONTAINER_BUILD_ARGS: '${{ matrix.build-args }}'
TARGET_BRANCH_NAME: 'origin/${{ matrix.target_branch }}'

steps:
Expand Down

0 comments on commit 0807e0c

Please sign in to comment.