Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid downloading large sprout param files #1570

Open
wants to merge 1 commit into
base: jl777
Choose a base branch
from

Conversation

leto
Copy link

@leto leto commented Jun 19, 2019

NOTE: This is a WIP and is not ready to be merged.

This patch allows a HUSH node to avoid downloading ~900MB of Sprout param files and fully sync without any problems, because the new HUSH mainnet has no Sprout transactions.

For Pirate, this gets us most of the way there, but more work needs to be done. My trick with Hush was to never initialize the data structures which store old Sprout params. With Pirate, some code might need to be modified to prevent dereferencing a null pointer.

Currently Pirate can sync 32 blocks and then coredumps in block 33 when trying to parse the first JoinSplit on the chain, inside CheckTransaction() :

https://gist.github.com/leto/32344417f28688f20810cecd3f0ec655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant