Avoid downloading large sprout param files #1570
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a WIP and is not ready to be merged.
This patch allows a HUSH node to avoid downloading ~900MB of Sprout param files and fully sync without any problems, because the new HUSH mainnet has no Sprout transactions.
For Pirate, this gets us most of the way there, but more work needs to be done. My trick with Hush was to never initialize the data structures which store old Sprout params. With Pirate, some code might need to be modified to prevent dereferencing a null pointer.
Currently Pirate can sync 32 blocks and then coredumps in block 33 when trying to parse the first JoinSplit on the chain, inside
CheckTransaction()
:https://gist.github.com/leto/32344417f28688f20810cecd3f0ec655