Merge pull request hyperspy#3456 from ericpre/fix_mpl3.10

Replace iterators by list in `hs.plot.plot_spectra` which fails with matplotlib 3.10
jlaehne · Nov 4, 2024 · 462a7b2 · 462a7b2
2 parents 021de72 + 0be9ecb
commit 462a7b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/hyperspy/drawing/utils.py b/hyperspy/drawing/utils.py
@@ -1577,7 +1577,7 @@ def _reverse_legend(ax_, legend_loc_):
             handles = line.legend_handles
         else:
             handles = line.legendHandles
-        ax_.legend(reversed(handles), reversed(labels), loc=legend_loc_)
+        ax_.legend(handles[::-1], labels[::-1], loc=legend_loc_)
 
     # Before v1.3 default would read the value from prefereces.
     if style == "default":

diff --git a/upcoming_changes/3456.bugfix.rst b/upcoming_changes/3456.bugfix.rst
@@ -0,0 +1 @@
+Fix bug in :func:`~.api.plot.plot_spectra` when reversing legend handles since matplotlib expects a list and not an iterator.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug in :func:`~.api.plot.plot_spectra` when reversing legend handles since matplotlib expects a list and not an iterator.