Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven, x-dead-letters-exchange, JSON Object #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sergiogouveia
Copy link

This developments were based on a mix of jeanml and pramodanarase last developments.
Changes:

  • updated ReadMe File
  • Project converted to Maven
  • Added x-dead-letters-exchange argument to queues
  • Consumer Sampler Data is now in JSON Object format
  • jar file includes JSON Object needed dependencies

@sergiogouveia sergiogouveia changed the title Change list Maven, x-dead-letters-exchange, JSON Object Apr 6, 2016
@jlavallee
Copy link
Owner

Thanks for these. I'm not particularly interested in moving to Maven, could you split out the other changes?

@PeteTh
Copy link

PeteTh commented Feb 13, 2017

I would like these fixes to be merged as we need the functionality to assert against the reponse (which this fixes) and assert against the correlation_id in the header.

I personally think moving to Maven is a good idea, it's pretty defacto now. This project should build with either Maven or Gradle I think.

The changes added in this pull request need new dependencies which it looks like the author has included as new maven dependencies.

@jlavallee
Copy link
Owner

jlavallee commented Feb 13, 2017

Please split out the move to maven into a separate pull request. I want to accept the fixes, and I want to be able to do so without being required to change how the project builds.

Sergio Gouveia and others added 2 commits June 1, 2017 18:40
integer AMQP header namew with tag (int)
@niclarcipretti
Copy link

Will this ever be merged? I't not possible to add a producer to a queue that has dead letter configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants