proper error message in case of invalid invoice total when request a …

…girocode. close #2349
jlawyerorg · Mar 24, 2024 · 632d44f · 632d44f
1 parent db8f0dd
commit 632d44f
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/j-lawyer-client/src/com/jdimension/jlawyer/client/editors/files/InvoiceDialog.java b/j-lawyer-client/src/com/jdimension/jlawyer/client/editors/files/InvoiceDialog.java
@@ -2432,9 +2432,21 @@ private void cmdTimesheetPositionsActionPerformed(java.awt.event.ActionEvent evt
 
     private void cmdGiroCodeActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_cmdGiroCodeActionPerformed
         try {
-            GirocodeDialog gcd = new GirocodeDialog(this, true, cf.parse(this.lblInvoiceTotal.getText()).floatValue(), this.lblInvoiceNumber.getText());
-            FrameUtils.centerDialog(gcd, this);
-            gcd.setVisible(true);
+            float amount=0f;
+            boolean validAmount=false;
+            try {
+                amount=cf.parse(this.lblInvoiceTotal.getText()).floatValue();
+                validAmount=true;
+            } catch (Throwable t) {
+                log.error("error parsing invoice total: " + this.lblInvoiceTotal.getText(), t);
+            }
+            if(validAmount) {
+                GirocodeDialog gcd = new GirocodeDialog(this, true, amount, this.lblInvoiceNumber.getText());
+                FrameUtils.centerDialog(gcd, this);
+                gcd.setVisible(true);
+            } else {
+                JOptionPane.showMessageDialog(this, "Der Rechnungsbetrag ist ungültig.", com.jdimension.jlawyer.client.utils.DesktopUtils.POPUP_TITLE_HINT, JOptionPane.INFORMATION_MESSAGE);
+            }
         } catch (Exception ex) {
             log.error("error loading invoice document", ex);
             JOptionPane.showMessageDialog(this, "Girocode kann nicht erstellt werden: " + ex.getMessage(), com.jdimension.jlawyer.client.utils.DesktopUtils.POPUP_TITLE_ERROR, JOptionPane.ERROR_MESSAGE);