Skip to content

Commit

Permalink
kola/tests: Use disk label for mount partitions test
Browse files Browse the repository at this point in the history
On s390x, the disk order is not guaranteed, so it is better to use unique
labels instead of `/dev/vda`.

Additional fixes:
- Fix spelling mistake.
- Do not assign variable name for unused argument.

Signed-off-by: Jan Schintag <[email protected]>
  • Loading branch information
jschintag committed Apr 16, 2024
1 parent d84bc0f commit 583522a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mantle/kola/tests/ignition/mount.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func init() {
Platforms: []string{"qemu"},
Tags: []string{"ignition"},
})
// create new partiitons with disk `vda`
// create new partitions on disk labeled `coreos-boot-disk
register.RegisterTest(&register.Test{
Name: "coreos.ignition.mount.partitions",
Description: "Verify that we can create new partitions through Ignition.",
Expand Down Expand Up @@ -89,7 +89,7 @@ func testMountPartitions(c cluster.TestCluster) {

ignDisks := []types.Disk{
{
Device: "/dev/vda",
Device: "/dev/disk/by-id/coreos-boot-disk",
Partitions: []types.Partition{
{
Label: util.StrToPtr("CONTR"),
Expand All @@ -108,7 +108,7 @@ func testMountPartitions(c cluster.TestCluster) {
createClusterValidate(c, config, platform.MachineOptions{}, ignDisks, 2097152, 1024)
}

func createClusterValidate(c cluster.TestCluster, config types.Config, options platform.MachineOptions, ignDisks []types.Disk, v2size int, v3sizeMiB int) {
func createClusterValidate(c cluster.TestCluster, config types.Config, options platform.MachineOptions, ignDisks []types.Disk, _ int, v3sizeMiB int) {
var m platform.Machine
var err error
config.Storage.Disks = ignDisks
Expand Down

0 comments on commit 583522a

Please sign in to comment.