Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Visa list, add Amex and Mastercard lists, fixes (unicode characters, private ranges), get_all_mccs_dict utility function #8

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

peter277
Copy link
Contributor

Various improvements and fixes:

  • Visa list: add new MCCs and amend descriptions to align with latest merchant data standards manual
  • Add Mastercard and Amex MCC data (links to reference data added to README)
  • Fix incorrect private_ranges.csv
  • All lists: convert unicode characters to ASCII for greater compatibility: em dash — to --, en dash – to -, ’ to ', é to e
  • Add utility function get_all_mccs_dict: Returns list of dictionaries for all MCCs, e.g. for easy conversion to pandas data frame using DataFrame(get_all_mccs_dict())

@jleclanche
Copy link
Owner

@peter277 thanks for the PR! Looks good - can you just fix the linting checks?

…for all MCCs, e.g. for easy conversion to pandas data frame using `DataFrame(get_all_mccs_dict())`
@peter277
Copy link
Contributor Author

@peter277 thanks for the PR! Looks good - can you just fix the linting checks?

@jleclanche Should be fixed now - I've reordered the imports to pass isort.

@jleclanche jleclanche merged commit 9913ec6 into jleclanche:master Apr 22, 2024
5 checks passed
@jleclanche
Copy link
Owner

Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants