Update tags with optional replace existing tags flag. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocribbz
commented
Apr 28, 2017
| class TagManager(models.Manager): | ||
| def update_tags(self, obj, tag_names): | ||
| def update_tags(self, obj, tag_names, replace_existing=True): |
bocribbz
commented
Apr 28, 2017
| updated_tag_names = [t.lower() for t in updated_tag_names] | ||
|
|
||
| # Remove tags which no longer apply |
bocribbz
commented
Apr 28, 2017
| object_id=obj.pk, | ||
| tag__in=tags_for_removal, | ||
| ).delete() | ||
|
|
||
| # Add new tags | ||
| current_tag_names = [tag.name for tag in current_tags] |
There was a problem hiding this comment.
bellow are pep8 fixes. check the tests ;)
bocribbz
commented
Apr 28, 2017
| @@ -234,6 +295,26 @@ def test_update_tags(self): | |||
| self.failUnless(get_tag('baz') in tags) | |||
| self.failUnless(get_tag('foo') in tags) | |||
|
|
|||
| def test_update_tags_without_replace(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to update tags by appending, instead of replacing existing ones.