-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Election Leaflets Upload #1
Open
lach-wright
wants to merge
21
commits into
jmacmullin:master
Choose a base branch
from
lach-wright:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Select picture from library or new from camera -Place selected picture in a table view -Allow pictures to be deleted from table view -If no pictures are selected, display instructions graphic
This reverts commit a2e4424.
This reverts commit 25145f0.
-Upload images button added to footer of table view -Styling of the button not complete
- Added styling to upload button - Prevent table editing whilst displaying instructions
-Networking added to upload images and recieve leaflet key -Alert views displayed to show when uploading and when errors occur
-TVC added to storyboard for leaflet details -Prototype cells setup for text details and list details -Layout (i.e. row height) code added to TVC -Display (i.e. row labels for lists) added to TVC
-Added subclass of UITableViewCell for the two cells in the details TVC with text inputs -Setup properties on the details TVC to access all text inputs
-Methods to resize tableView based on keyboard -Scroll to text view needs to be updated to account for keyboard -Scroll to text field still to be implemented
-Pass dictionary of options to pick list TVC -Pass array or ordered keys to pick list TVC -Moved button custom formmatting to UIButton subclass
-Pick lists passing data back to details TVC -Details TVC displays selected values -Upload of data still required
To do: - Fix ddl form parts should return the ID - Implement dynamic methods for chk form paths - Add form validation
To do: -Form validation -Checkbox values upload
-Added method to add multi-select list data to upload -HTML parsing of upload response for validation -Methods to message user on upload of leaflet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jake,
I've attempted to implement the leaflet upload process. I've put in a couple of extra controller compared with the original structure (for the second step of the upload process and to select items from the large lists). I've tested it on a local version of the election leaflets that I setup (using the simulator), but there might be some edge cases I've missed.
Let me know if you spot anything that needs fixing.
Cheers,
Lachlan